Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-96556 || New user displayed invalid in recipient field #4079

Closed
wants to merge 6 commits into from
Closed

EPMRPP-96556 || New user displayed invalid in recipient field #4079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb444ea
EPMRPP-96556 || New user displayed invalid in recipient field
iso9000t Nov 1, 2024
4dbfaf7
EPMRPP-96118 || Revert changes for the Show button (#4078)
maria-hambardzumian Nov 1, 2024
51e9543
EPMRPP-96556 || New user displayed invalid in recipient field
iso9000t Nov 1, 2024
5c1e724
EPMRPP-96556 || Code Review fixes - 2
iso9000t Nov 4, 2024
94930e2
Merge branch 'fix/EPMRPP-96556-new-user-displayed-invalid-in-recipien…
iso9000t Nov 4, 2024
22c9a0e
EPMRPP-96556 || Code Review fixes - 3
iso9000t Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...nents/widgets/singleLevelWidgets/charts/investigatedTrendChart/config/launchModeConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ export const getLaunchModeConfig = ({
}) => {
const colors = {};
const columns = [];
// EPMRPP-96393 (GitHub #2381): Changed sorting from -item.number to startTime-based sorting
// for consistency across all chart widgets. This ensures chronological ordering
// based on actual launch times rather than launch names/numbers.
const sortedResult = content.sort((a, b) => {
const startTimeA = new Date(a.startTime);
const startTimeB = new Date(b.startTime);
Expand Down
7 changes: 2 additions & 5 deletions app/src/controllers/log/sagas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import {
} from 'controllers/log/nestedSteps/actionCreators';
import { createNamespacedQuery } from 'common/utils/routingUtils';
import { FAILED } from 'common/constants/testStatuses';
import { ERROR, FATAL } from 'common/constants/logLevels';
import { ERROR } from 'common/constants/logLevels';
import {
fetchErrorLogs,
clearLogPageStackTrace,
Expand Down Expand Up @@ -130,9 +130,6 @@ function* fetchAllErrorLogs({
excludeLogContent = true,
level,
}) {
const logMessages = yield select(logItemsSelector);
const requiresErrorLogLocation = logMessages.some((log) => [ERROR, FATAL].includes(log.level));

const { id } = logItem;
const { activeProject, query, filterLevel } = yield call(collectLogPayload);
let retryId = null;
Expand All @@ -142,7 +139,7 @@ function* fetchAllErrorLogs({
}
let cancelRequest = () => {};
try {
if (logViewMode === DETAILED_LOG_VIEW && requiresErrorLogLocation) {
if (logViewMode === DETAILED_LOG_VIEW) {
yield put(
fetchDataAction(namespace)(
URLS.errorLogs(activeProject, retryId || id, level || filterLevel),
Expand Down
4 changes: 4 additions & 0 deletions ...tainer/content/notifications/modals/addEditNotificationModal/addEditNotificationModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ import { RadioGroup } from 'componentLibrary/radioGroup';
import { EMAIL } from 'common/constants/pluginNames';
import { FieldTextFlex } from 'componentLibrary/fieldTextFlex';
import { ruleField } from 'pages/inside/projectSettingsPageContainer/content/notifications/propTypes';
import { fetchProjectAction } from 'controllers/project/actionCreators';
import { projectIdSelector } from 'controllers/pages';
import { capitalizeWord } from '../util';
import { RecipientsContainer } from './recipientsContainer';
import { LaunchNamesContainer } from './launchNamesContainer';
Expand Down Expand Up @@ -213,12 +215,14 @@ const AddEditNotificationModal = ({
}) => {
const { formatMessage } = useIntl();
const dispatch = useDispatch();
const projectId = useSelector(projectIdSelector);
const [isEditorShown, setShowEditor] = React.useState(data.notification.attributes.length > 0);
const attributesValue =
useSelector((state) => attributesValueSelector(state, ATTRIBUTES_FIELD_KEY)) ?? [];

useEffect(() => {
initialize(data.notification);
dispatch(fetchProjectAction(projectId, false));
}, []);

const caseOptions = [
Expand Down
Loading