Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-92207 || Improve event "page_view" for Google Analytics 4 #4133

Conversation

iso9000t
Copy link
Contributor

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.97%. Comparing base (87defaf) to head (85666b9).

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #4133   +/-   ##
=============================================
  Coverage         61.97%   61.97%           
=============================================
  Files                85       85           
  Lines               960      960           
  Branches            141      142    +1     
=============================================
  Hits                595      595           
  Misses              334      334           
  Partials             31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iso9000t iso9000t merged commit 611be49 into feature/orgs Dec 18, 2024
8 checks passed
@iso9000t iso9000t deleted the feature/EPMRPP-92207-improve-event-page-view-google-analytics-4 branch December 18, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants