Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-97895 || Add validation on entered URL #4134

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented Dec 18, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (68a3557) to head (c8cca48).

Files with missing lines Patch % Lines
...pp/src/common/utils/validation/commonValidators.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4134      +/-   ##
===========================================
- Coverage    61.17%   61.14%   -0.03%     
===========================================
  Files           81       81              
  Lines          904      906       +2     
  Branches       136      136              
===========================================
+ Hits           553      554       +1     
- Misses         323      324       +1     
  Partials        28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlazarQSO BlazarQSO merged commit 73d087c into develop Dec 20, 2024
10 checks passed
@BlazarQSO BlazarQSO deleted the feature/EPMRPP-97895-add-validation-entered-url branch December 20, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants