EPMRPP-97554 || review fix - 2

reportportal · Dec 20, 2024 · 084750f · 084750f
1 parent 27bbf9b
commit 084750f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/src/components/notification/notification.module.scss b/src/components/notification/notification.module.scss
@@ -39,10 +39,8 @@
     .title {
       text-align: start;
       font-family: var(--rp-ui-base-font-family);
-      @include font-scale();
+      @include font-scale(x2-medium);
       font-weight: $fw-semi-bold;
-      line-height: 24px;
-      font-size: 15px;
       color: var(--rp-ui-base-bg-000);
       display: -webkit-box;
       max-width: 100%;

diff --git a/src/components/notification/notification.tsx b/src/components/notification/notification.tsx
@@ -1,8 +1,8 @@
-import { CSSProperties, FC, ReactElement, useEffect } from 'react';
+import { FC, ReactElement, useEffect } from 'react';
 import { NotificationProps, NotificationType } from '@components/notification/types';
 import styles from './notification.module.scss';
 import classNames from 'classnames/bind';
-import { CloseIcon, ErrorIcon, InfoIcon, SuccessIcon } from '@/components';
+import { CloseIcon, ErrorIcon, InfoIcon, SuccessIcon } from '@components/icons';
 
 const cx = classNames.bind(styles);
 const ERROR_DURATION = 7000;
@@ -15,7 +15,6 @@ export const Notification: FC<NotificationProps> = ({
   icon = null,
   type = NotificationType.INFO,
   duration = DEFAULT_DURATION,
-  description,
   className,
 }): ReactElement => {
   const adjustedDuration = type === NotificationType.ERROR ? ERROR_DURATION : duration;
@@ -41,14 +40,10 @@ export const Notification: FC<NotificationProps> = ({
     }
   };
   return (
-    <div
-      className={cx('notification-container', type, className)}
-      style={{ '--duration': `${duration}ms` } as CSSProperties}
-    >
+    <div className={cx('notification-container', type, className)}>
       <div className={cx('icon-wrapper')}>{getIcon()}</div>
       <div className={cx('content-wrapper')}>
-        <div className={cx('title')}>{title}</div>
-        {description && <div className={cx('description')}>{description}</div>}
+        <h2 className={cx('title')}>{title}</h2>
       </div>
       <button
         className={cx('close-button')}

diff --git a/src/components/notification/types.ts b/src/components/notification/types.ts
@@ -1,4 +1,4 @@
-import { ReactElement, ReactNode } from 'react';
+import { ReactElement } from 'react';
 export enum NotificationType {
   INFO = 'info',
   SUCCESS = 'success',
@@ -11,6 +11,5 @@ export interface NotificationProps {
   icon?: ReactElement | null;
   type?: NotificationType;
   duration?: number;
-  description?: ReactNode;
   className?: string;
 }