Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ActiveSupport 7.1.x #50

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Nov 17, 2023

I met the following error if use with ActiveSupport 7.1.x.

bundle exec exe/wrapbox --help
bundler: failed to load command: exe/wrapbox (exe/wrapbox)
/home/kenji/.local/share/rtx/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.1.2/lib/active_support/core_ext/array/conversions.rb:108:in `<class:Array>': undefined method `deprecator' for ActiveSupport:Module (NoMethodError)

  deprecate to_default_s: :to_s, deprecator: ActiveSupport.deprecator
                                                          ^^^^^^^^^^^

I've added require "active_support" before load other active_support libraries to fix the issue.

See

@okkez okkez requested a review from joker1007 November 17, 2023 00:33
Copy link
Contributor

@joker1007 joker1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks!!

@joker1007 joker1007 merged commit 8b7c105 into master Nov 17, 2023
8 checks passed
@joker1007 joker1007 deleted the support-activesupport-7.1.x branch November 17, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants