Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reqnroll.Assist.Dynamic #377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

olegKoshmeliuk
Copy link
Member

@olegKoshmeliuk olegKoshmeliuk commented Dec 30, 2024

🤔 What's changed?

Added ported version of SpecFlow.Assist.Dynamic

⚡️ What's your motivation?

Few times user requested this lib to be as part of Reqnroll.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Suggestion about better documentation? Technicaly it's library and argument transformation and not a plugin.
Currently this libary tests are not running as part of CI. Better way to implement it?
copyright, credits, authors fields in Reqnroll.Assist.Dynamic.nuspec file. because i just ported library with few changes.

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@olegKoshmeliuk olegKoshmeliuk marked this pull request as ready for review January 2, 2025 19:09
@olegKoshmeliuk
Copy link
Member Author

No need fully review code. just give feedback questions in PR description.
Maybe i will do some code cleanup before final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant