Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next version (primeng) #3805

Draft
wants to merge 4 commits into
base: staging
Choose a base branch
from
Draft

Next version (primeng) #3805

wants to merge 4 commits into from

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 18, 2024

No description provided.

Garfield-fr and others added 4 commits December 4, 2024 08:03
@Garfield-fr
chore(schema): use select instead of selectWithSort
f5b2b43 
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr
chore(schema): update schemas
774d062 
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma
ui: uses primeng for the frontend
a557424 
* Adds missing format alias on the the REST API.
* Adds placeholder on the contries editor.
* All document detailed view tabs is done in angular.
* Removes useless document views.
* Removes useless document jinja template filters and their corresponding tests.
* Adds layer to css styles to avoid primeng and bootstrap conflicts.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma @Garfield-fr
primeng: fix patron editor
d037540 
* Removes css class for the professional view.
* Adapts the main search component to the new ui version.
* Fixes several details in the patron editor.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. dev: documentation About changelog, release notes, installation procedures, gh templates... f: user management f: data migration Data migration from a legacy system or a previous version labels Dec 18, 2024
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Dec 19, 2024 •
edited by PascalRepond
Loading

PO tests

  • Editor: cannot select a contribution role. [REP: the editor has not been done yet]
  • Global style:
    • A lot of colours seem kind of washed out. Example: text in the description tab (I would prefer full black instead of gray), menu buttons. Could everything be a little darker to have more contrast/readability?
    • The global font-size would be better at "1" instead of 0.85
    • Brief views: slightly reduce the width of the facet column (by ~1/4)
    • Brief views: slightly reduce the width of the result list (by ~1/3)
    • Brief views: add icons to the sort menu and remove the "..."
  • Pro detailed views:
    • Document detail: The first item should be expanded on page load
    • The delete button is grayed out but doesn't say why (there was a modal in the previous version to say "2 holdings attached")
    • Document/item detail: "operation history" and "circulation history" buttons should be outline-gray
    • Add left and right margins around the content for wide screens so that the data is not spread on the whole viewport. (ILL requests, patron, item? to be experimented)
    • [nice-to-have] Use gray card headers (ILL requests, patron, item?)
  • Flash message: a little bit too much space between title and content
    image
  • Alternate color style for lists: [nice-to-have] the first row should be gray
  • The user menu is always outside the window and buttons don't work:
    image
  • Editors: $ref dropdown fields option is not loaded on page init, I need to touch the field to see it (e.g. ILL request editor: pickup location)
  • Sometimes going for a "edit" or "delete" button, I hover the menu and it automatically opens, hiding the button I want. Is there a setting to make these menus open on click instead of hover?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates... developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @ManaDeweerdt @Garfield-fr