Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eframe to 0.30.0 #53

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Upgrade eframe to 0.30.0 #53

wants to merge 7 commits into from

Conversation

c-git
Copy link

@c-git c-git commented Dec 30, 2024

This turned out to be a bigger PR than I planned. But submitted for review as I'd already completed it to the best of my ability. There are open questions that I was unable to answer due to lack of context.

Open questions:

  • I wasn't sure how you wanted to deal with the warning about the lints priority and thus didn't do anything about them for now. Lints in question are future_incompatible, nonstandard_style, and rust_2018_idioms in the workspace Cargo.toml
  • I updated the index.html from the one in the eframe template and it resulted false positive for lychee. I think it is a false positive because after trunk build the manifest.json is correctly referenced.

Changes made

  • Bumped the MSRV to the same as eframe
  • Corrected the name of the page in index.html because it was saying table demo
  • Upgraded the version of eframe
  • Added an allow to stop the clippy lint about unused mut ref because I think it was there to make the API the same between both WASM and Native.
  • Ran cargo update because was unable to compile after the MSRV and eframe upgrades without running it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant