Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port codegen arrow deserialization to arrow-rs #8375

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 9, 2024

Related

What

Port arrow deserialization codegen to arrow-rs

Unfortunately something broke in the tensor deserialization, likely due to interior mutability:

TODO

  • Run @rerun-bot full-check

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
10d58b6 https://rerun.io/viewer/pr/8375 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as draft December 9, 2024 20:10
@emilk emilk changed the title Add ZipValidity Port codegen arrow deserializtion to arrow-rs Dec 9, 2024
@emilk emilk force-pushed the emilk/arrow-deserializer branch from 0ec5a67 to b329d4a Compare December 18, 2024 14:06
@emilk emilk force-pushed the emilk/arrow-deserializer branch from f84e718 to 3e792d2 Compare December 18, 2024 16:05
@emilk emilk marked this pull request as ready for review December 19, 2024 09:53
@emilk
Copy link
Member Author

emilk commented Dec 19, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12410292950

@abey79 abey79 changed the title Port codegen arrow deserializtion to arrow-rs Port codegen arrow deserialization to arrow-rs Dec 19, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Dec 19, 2024

Heads up: full check is failing

@emilk emilk marked this pull request as draft December 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants