Skip to content
This repository has been archived by the owner on Dec 27, 2020. It is now read-only.

FIXBIK: Add fixbik, a small utility to trim headers off EMI movies. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoseJX
Copy link
Contributor

@JoseJX JoseJX commented Apr 5, 2014

This is just a small utility to remove the SMUSH headers from the EMI movies. With the headers removed, you can watch the movies in mplayer. I wrote this because I wanted to check that all of the EMI movies were full screen movies. They are!

@JoseJX JoseJX changed the title FIXBIK: Add fixbik, small utility to trim headers off EMI movies. FIXBIK: Add fixbik, a small utility to trim headers off EMI movies. Apr 5, 2014
while(1) {
fread(l, 4, 1, rfd);
// Found it, seek back and exit the loop
if(!strncmp(l, "BIKi", 4)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had a better way to scan for the BIK header, but I can't find it now... @chkr-private can you comment?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing implementation in ResidualVM is here https://github.com/residualvm/residualvm/blob/master/engines/grim/movie/bink.cpp
I think it would be applicable if the files in question are using the SMUSH header.

@JoseJX
Copy link
Contributor Author

JoseJX commented Apr 5, 2014

Here's an updated version to address your review, thanks!

@klusark
Copy link
Member

klusark commented Apr 5, 2014

Did you see my other two comments?

@JoseJX
Copy link
Contributor Author

JoseJX commented Apr 5, 2014

I did, but the one that isn't incorporated into this is the last one regarding using existing code for identifying the SMUSH header. It's probably a good idea to use that. Is there a way to link the existing code in ResidualVM from the tools?

@klusark
Copy link
Member

klusark commented Apr 5, 2014

I somehow missed adding the buffer.

You can't link any code from residualvm unfortunately. A lot of the code is duplicated for that reason. Just copying it would be fine.

@JoseJX
Copy link
Contributor Author

JoseJX commented Apr 6, 2014

This new version reads in the SMUSH header, finds the size and then skips it just like the code that you pointed to. Instead of pulling in all of the common code for stream handling, I just implemented it in a similar fashion. I hope that's okay!

@JoseJX
Copy link
Contributor Author

JoseJX commented Apr 6, 2014

Updated again for syntax style, sorry!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants