General modification for storage server library #59
Conversation
|
Test FAILed. |
libjiffy/src/jiffy/storage/block.cpp
Outdated
| if (impl_ == nullptr) { | ||
| throw std::invalid_argument("No such type " + type); | ||
| } | ||
| } | ||
|
|
||
| void block::destroy() { | ||
| LOG(log_level::info) << "Destroying partition " << impl_->name() << " on block " << id_; | ||
| //LOG(log_level::info) << "Destroying partition " << impl_->name() << " on block " << id_; |
| std::vector<command> OPS, | ||
| int timeout_ms) | ||
| : fs_(std::move(fs)), path_(path), status_(status), timeout_ms_(timeout_ms) { | ||
| (void) OPS; |
| const std::string &auto_scaling_host, | ||
| int auto_scaling_port) | ||
| : chain_module(manager, name, metadata, {}) { | ||
| (void) directory_host; |
There was a problem hiding this comment.
I am guessing you are doing this to suppress the unused warning. Instead of (void) varname;, you can just avoid naming the variables, e.g.,
default_partition::default_partition(block_memory_manager *manager,
const std::string &name,
const std::string &metadata,
const utils::property_map &,
const std::string &,
int,
const std::string &,
int)There was a problem hiding this comment.
Exactly! Thanks for the suggestion.
Fixed
| @@ -16,7 +16,7 @@ void storage_manager::create_partition(const std::string &block_id, | |||
| const std::map<std::string, std::string> &conf) { | |||
| auto bid = block_id_parser::parse(block_id); | |||
| storage_management_client client(bid.host, bid.management_port); | |||
| LOG(log_level::info) << "setup partition on " << bid.host << ":" << bid.management_port; | |||
| //LOG(log_level::info) << "Creating partition name : " << name << " on " << bid.host << ":" << bid.management_port; | |||
There was a problem hiding this comment.
Either put back the LOG statements, or remove them. Same thing for all the commented out log statements below..
| @@ -42,6 +43,10 @@ void subscription_map::clear() { | |||
| std::lock_guard<std::mutex> lock{mtx_}; | |||
| subs_.clear(); | |||
| } | |||
| // TODO fix this | |||
| void subscription_map::send_failure() { | |||
There was a problem hiding this comment.
What is this supposed to do? Maybe put a more descriptive comment about what this function is supposed to do if you don't intend to implement it now..
| virtual ~partition() { | ||
| client_map_.send_failure(); | ||
| client_map_.clear(); | ||
| // TODO need to figure out if we want to notify an error to the subscripted clients after a delete of partition |
There was a problem hiding this comment.
We probably should -- create an issue unless we have one already
There was a problem hiding this comment.
Fixed, this refers to issue #46
Co-Authored-By: Anurag Khandelwal <anuragk@berkeley.edu>
|
Test FAILed. |
|
Test FAILed. |
|
All fixed for this PR |
|
Test FAILed. |
No description provided.