Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen the pull request #174 by user @guijan, however, I disagree with the
code style and the argument against using
echo
.I believe it is easier to validate the
autogen.sh
shell script command linearguments and, albeit more readable by just expanding the first positional
parameter and ignoring the rest. Furthermore, the
autogen.sh
shell scriptfrom #174 would consider an empty string as valid (e.g.,
./autogen.sh ''
).If the script were to become more complex, arguments can be parsed in other ways.
Regarding the use of the
echo
command, there should not be any significantportability issue because all strings or arguments do not contain escape
sequences to be interpreted. When more formatting is required,
echo
can bereplaced to prevent errors because of the differences in their options. For
more information:
While editing the
autogen.sh
shell script I noticed there was abackslash near the end of a line with an
rm
command. Is there some linelength limit that I am not aware of?