[DRAFT] Feature/retestid without gm

[roesslerj]

• the code follows the Clean Code guidelines.
• the necessary tests are either created or updated.
• all status checks (Travis CI, SonarCloud, etc.) pass.
• your commit history is cleaned up.
• you updated the changelog.
• you updated necessary documentation within retest/docs.

Since retestId is now created deterministically, we can reference it before we even have a Golden Master. This is gonna be helpful in a variety of situations, but especially when generating Surili tests.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

40.0% Coverage
0.0% Duplication

[beatngu13]

Having a deterministic RetestIdProvider is not a contract to my knowledge, so we cannot rely on this. For example, we still ship RandomSuffixRetestIdProvider and the user is free to provide a custom implementation. Then this doesn't work.

If we want RetestIdProviders to be deterministic in general, we have to document and require this contract (like e.g. equals requires an equivalence relation), otherwise there will be undefined behavior.

Also, what happens if slight state changes lead to different counts? We no longer lookup the element in the old state and do a 1-on-1 assignment, instead we select it solely on the basis of the retest ID I guess?

It would rather mark this as a draft. We have to discuss the determinism and we need proper tests, at least for the aforementioned situations. If we do such a "drastic" change without tests, and no existing tests are failing, we are doing something wrong.

[beatngu13]

Off-topic: How to convert an existing PR into a draft? 🤷‍♂️

[diba1013]

Off-topic: How to convert an existing PR into a draft? 🤷‍♂️

This is not possible as far as I am aware: isaacs/github#1547

[beatngu13]

Closed until someone has time to address the open issues as part of #570.