fix: typings for server member broke in recent api release

revoltchat · Mar 15, 2024 · 6355792 · 6355792
1 parent a4906f9
commit 6355792
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/classes/Server.ts b/src/classes/Server.ts
@@ -578,15 +578,7 @@ export class Server {
     });
 
     if (existing) return existing;
-
-    const member = await this.#collection.client.api.get(
-      `/servers/${this.id as ""}/members/${userId as ""}`
-    );
-
-    return this.#collection.client.serverMembers.getOrCreate(
-      member._id,
-      member
-    );
+    return this.#collection.client.serverMembers.fetch(this.id, userId);
   }
 
   #synced: undefined | "partial" | "full";

diff --git a/src/collections/ServerMemberCollection.ts b/src/collections/ServerMemberCollection.ts
@@ -38,9 +38,13 @@ export class ServerMemberCollection extends ClassCollection<
     const member = this.get(serverId + userId);
     if (member) return member;
 
-    const data = await this.client.api.get(
-      `/servers/${serverId as ""}/members/${userId as ""}`
-    );
+    const data = (await this.client.api.get(
+      `/servers/${serverId as ""}/members/${userId as ""}`,
+      {
+        roles: false,
+      }
+      // TODO: fix typings in revolt-api
+    )) as API.Member;
 
     return this.getOrCreate(data._id, data);
   }