Skip to content

Commit

Permalink
Use fiber for errors as well
Browse files Browse the repository at this point in the history
  • Loading branch information
danog committed Dec 7, 2024
1 parent 41098ec commit 8e4dbf1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/EventLoop/Internal/AbstractDriver.php
Original file line number Diff line number Diff line change
Expand Up @@ -641,9 +641,10 @@ private function createErrorFiber(): void
$exception = Fiber::suspend($this->internalSuspensionMarker);
($this->errorHandler)($exception);

Check failure on line 642 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

PossiblyNullFunctionCall

src/EventLoop/Internal/AbstractDriver.php:642:21: PossiblyNullFunctionCall: Cannot call function on possibly null value (see https://psalm.dev/094)

Check failure on line 642 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.1

PossiblyNullFunctionCall

src/EventLoop/Internal/AbstractDriver.php:642:21: PossiblyNullFunctionCall: Cannot call function on possibly null value (see https://psalm.dev/094)

Check failure on line 642 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

PossiblyNullFunctionCall

src/EventLoop/Internal/AbstractDriver.php:642:21: PossiblyNullFunctionCall: Cannot call function on possibly null value (see https://psalm.dev/094)
} catch (\Throwable $exception) {
$errorHandler = $this->errorHandler;
$this->interrupt = static fn () => $exception instanceof UncaughtThrowable
? throw $exception
: throw UncaughtThrowable::throwingErrorHandler($this->errorHandler, $exception);
: throw UncaughtThrowable::throwingErrorHandler($errorHandler, $exception);

Check failure on line 647 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.2

PossiblyNullArgument

src/EventLoop/Internal/AbstractDriver.php:647:73: PossiblyNullArgument: Argument 1 of Revolt\EventLoop\UncaughtThrowable::throwingErrorHandler cannot be null, possibly null value provided (see https://psalm.dev/078)

Check failure on line 647 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.1

PossiblyNullArgument

src/EventLoop/Internal/AbstractDriver.php:647:73: PossiblyNullArgument: Argument 1 of Revolt\EventLoop\UncaughtThrowable::throwingErrorHandler cannot be null, possibly null value provided (see https://psalm.dev/078)

Check failure on line 647 in src/EventLoop/Internal/AbstractDriver.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

PossiblyNullArgument

src/EventLoop/Internal/AbstractDriver.php:647:73: PossiblyNullArgument: Argument 1 of Revolt\EventLoop\UncaughtThrowable::throwingErrorHandler cannot be null, possibly null value provided (see https://psalm.dev/078)
}
} while (true);
});
Expand Down

0 comments on commit 8e4dbf1

Please sign in to comment.