Do not update corrupted files hash by default #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"I have added one argument/option '-corruptupdate' which when used will update the CRC of any corrupted files (i.e. the current default behaviour). Without this option the code doesn't update the attribute/CRC and subsequent runs of the code will still show the file as corrupt. I have done it this way as in my view a corrupted file should remain flagged as corrupt until fixed (or some other actions is taken)." Source: rfjakob#26 (comment) There is one problem with not updating the checksum: You will not notice when the file gets corrupted again (unless you compare the checksum). Yes, however if the file is already corrupt, any further corruption is irrelevant until it is fixed. The way I see this working, with the patch, is thus: Case 1 - no action I run cshatag It detects a corrupt file. I do nothing at all I run cshatag The corrupt file is still flagged. Case 2 - fixing the corrupt file I run cshatag It detects a corrupt file. I fix the file and then on this file only... I run cshatag -corruptupdate - that will update the file and should no longer flag as corrupt. File is fixed, no longer shows as corrupt on further cshatag runs. Others will until they are fixed. That way any corruption will show on every run until such time as I specifically tell it to update the file, i.e. I have fixed it.
|
Merged as 09534f6 , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not update corrupted files hashes unless new
--corruptupdateflag is providedFixes #26