-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation ChromBackend #23
Conversation
I changed the .yml file, the checks should not fail on warnings anymore :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Phili! Thanks! Just some minor change requests.
Regarding the question if chromData()
should return a DataFrame
or data.frame
, I don't see a problem for data.frame
at the moment - so, given that it is also slightly more efficient, I would maybe change to data.frame
instead of DataFrame
.
Hi so I answered / addressed the comments, thanks for the advices ! I went through the documentation a bit more realised I missed removing some stuff also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks Phili!
Before merging make sure you fix the two comments/issues in the documentation.
Regarding reset()
- yes, we might want to add that to ProtGenerics, but for now define it also here. We can change later.
So there is still a lot lot to do but as discussed I am trying to reduce the size of the PR. I hope that does not make it too confusing.
The big changes are the clear separation between what is a peaksVariables and what is a chromvariables.
See
ChromBackend-functions.R
Also implementation of respective function for each such as
validPeaksData()
andvalidChromData()
Quick question:
chromData()
returns adata.frame
and notDataFrame
? I don't really see the issue for now..Next I will add the
ChromBackendMemory()
implementation, i have the code, just need to clean it.Also will look into some maintainer stuff, if you have advices don't hesitate.