Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jtreg-wrappers: Add runtime check for native clients #16

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

zzambers
Copy link
Collaborator

@zzambers zzambers commented Nov 6, 2023

This introduces custom jtreg properties, which track presence of native clients. Test can use them in @requires, so they are excluded, when native client is missing.

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

wicked! Will look into that tomorrow!

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

How does ti behave if the class is missing?
How does it behave when the testroot itself is missng, and jtreg will find unknown property?

@zzambers
Copy link
Collaborator Author

zzambers commented Nov 6, 2023

@judovana what do you mean by missing? Class SysDepsProps is part of testsuite. Jtreg reads information from TEST.ROOT and than compiles/uses it by itself.

If you would remove SysDepsProps or TEST.ROOT, tests, which use custom properties would indeed end with error..

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

I'm thinking what to expect, once sombody launches it in some weird way. If both are confirmed errors, I'm ok with that :)

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

Ok to merge by. Thanx for educative implementation!

@zzambers
Copy link
Collaborator Author

zzambers commented Nov 6, 2023

I'm thinking what to expect, once sombody launches it in some weird way. If both are confirmed errors, I'm ok with that :)

  • so if you remove TEST.ROOT or replace it with clean one, it is error
  • if you remove just SysDepsProps.java it prints message about it missing, test using it will not run (properties are probably blank/nil)

However if you insist I can invert conditions to e.g. bin.gnutlscli == "true" -> bin.gnutlscli != "false" in which case tests will run with class missing

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

nn, thats ok. TY!

@zzambers
Copy link
Collaborator Author

zzambers commented Nov 6, 2023

too late :)

@judovana
Copy link
Collaborator

judovana commented Nov 6, 2023

never to late O:)

@zzambers zzambers merged commit 8ae31b5 into rh-openjdk:master Nov 6, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants