First stab at validating wiki #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I like the approach, looks like all the errors except for "404 Not Found" are false positives errors though. |
rhagman
reviewed
Aug 13, 2019
test/Dockerfile
Outdated
| @@ -0,0 +1,10 @@ | |||
| FROM rust | |||
There was a problem hiding this comment.
Nice, but I have been thinking about changing the arduino/d1mini code to use micropython and try to keep the whole project to use as much python as possible. Maybe we could use the python implementation here instead?
fabianvf
force-pushed
the
validate-wiki
branch
from
534ab40
to
5d4f768
Compare
|
Yeah, the 403s from Amazon are because they block the requests user agent, I set it to something more real and that seems to be working (we could also skip those links if you prefer). I replaced the marker binary with my own script to validate the links as well. |
|
@rhagman how do you like this iteration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like this is able to validate the ebay links yet, unfortunately I suspect they return valid responses even on error.