RFCT: Start breaking up the UI into components #96
Conversation
rharish101
force-pushed
the
pr/modularize_the_ui
branch
from
32d9057 to
0374cf6
Compare
|
Rebased it on the latest main. Do you plan on adding more to this PR, or should I merge it? IMO it seems complete as a PR for the clock widget. |
rharish101
force-pushed
the
pr/modularize_the_ui
branch
from
0374cf6 to
9136573
Compare
|
It is complete, but I haven't tested the rebased version. |
|
Sorry for the delay, life happened and I forgot to come back to this. So, looking at the diff before and after, it seems that the only change is the #54 merging. I will try out this rebased version, but I doubt it will be broken. |
max-ishere
force-pushed
the
pr/modularize_the_ui
branch
from
9136573 to
a90a7ce
Compare
|
LGTM for the rebase. As for the CI failure, well, this seems to be a Rust version specific issue? The suggestion from clippy not only doesnt exist on my machine, it fails to complile if applied. |
|
I also rebased this onto master so this should be ready to merge now... The CI is bugging me though, because it will probably keep failing all the later checks. |
rharish101
force-pushed
the
pr/modularize_the_ui
branch
2 times, most recently
from
29b9e28 to
6223c2a
Compare
|
I got it to compile with the CI-suggested fix with Rust 1.75. Could you try it out and see if it compiles for you now? |
- Separate the clock from the Greeter component - Replace chrono with jiff - Add TOML config options for the clock widget - Update the README with config options - Minor misc. improvements
rharish101
force-pushed
the
pr/modularize_the_ui
branch
from
6223c2a to
b85168f
Compare
|
I forgot to do a |
|
Yup, it compiles |
This PR is part of my implementation of #85. I've noticed that it is not easy to "just do X", pretty much everything is tangled up into about 3 functions (a single
fn updatethat does everything in the app, the clock, the power buttons, the login, everything; a view generated by Relm; and the init function that sets absolutely every component up) that are "broken up" into separate steps (functions), but when you try to pull out one step into a separate component something else needs to be pulled out as well.So I decided it would be easiest to move as much of the UI components out of the
Greetercomponent before tackling the mess of a grid in the login ui.Anyways, here are the changes:
The key benefit is the customizability of the clock and use of
jiffcrate, which, unlikechrono, doesn't require timezones to be initialized before threading.