Merge pull request #437 from KKoukiou/rhbz#2308279

Reimplement error handling using error boundaries
rhinstaller · Sep 16, 2024 · 9fa0ba7 · 9fa0ba7
2 parents 8429c2c + 3c81a36
commit 9fa0ba7
Show file tree

Hide file tree

Showing 12 changed files with 263 additions and 328 deletions.
diff --git a/src/actions/localization-actions.js b/src/actions/localization-actions.js
@@ -24,66 +24,48 @@ import {
     getLocales,
 } from "../apis/localization.js";
 
-import { setCriticalErrorAction } from "./miscellaneous-actions.js";
-
 export const getLanguagesAction = () => {
     return async (dispatch) => {
-        try {
-            const languageIds = await getLanguages();
+        const languageIds = await getLanguages();
 
-            return Promise.all([
-                dispatch(getCommonLocalesAction()),
-                ...languageIds.map(language => dispatch(getLanguageDataAction({ language })))
-            ]);
-        } catch (error) {
-            dispatch(setCriticalErrorAction(error));
-        }
+        return Promise.all([
+            dispatch(getCommonLocalesAction()),
+            ...languageIds.map(language => dispatch(getLanguageDataAction({ language })))
+        ]);
     };
 };
 
 export const getLanguageDataAction = ({ language }) => {
     return async (dispatch) => {
-        try {
-            const localeIds = await getLocales({ lang: language });
-            const languageData = await getLanguageData({ lang: language });
-            const locales = await Promise.all(localeIds.map(async locale => await getLocaleData({ locale })));
+        const localeIds = await getLocales({ lang: language });
+        const languageData = await getLanguageData({ lang: language });
+        const locales = await Promise.all(localeIds.map(async locale => await getLocaleData({ locale })));
 
-            return dispatch({
-                payload: { languageData: { [language]: { languageData, locales } } },
-                type: "GET_LANGUAGE_DATA"
-            });
-        } catch (error) {
-            dispatch(setCriticalErrorAction(error));
-        }
+        return dispatch({
+            payload: { languageData: { [language]: { languageData, locales } } },
+            type: "GET_LANGUAGE_DATA"
+        });
     };
 };
 
 export const getLanguageAction = () => {
     return async (dispatch) => {
-        try {
-            const language = await getLanguage();
+        const language = await getLanguage();
 
-            return dispatch({
-                payload: { language },
-                type: "GET_LANGUAGE"
-            });
-        } catch (error) {
-            dispatch(setCriticalErrorAction(error));
-        }
+        return dispatch({
+            payload: { language },
+            type: "GET_LANGUAGE"
+        });
     };
 };
 
 export const getCommonLocalesAction = () => {
     return async (dispatch) => {
-        try {
-            const commonLocales = await getCommonLocales();
+        const commonLocales = await getCommonLocales();
 
-            return dispatch({
-                payload: { commonLocales },
-                type: "GET_COMMON_LOCALES"
-            });
-        } catch (error) {
-            dispatch(setCriticalErrorAction(error));
-        }
+        return dispatch({
+            payload: { commonLocales },
+            type: "GET_COMMON_LOCALES"
+        });
     };
 };
diff --git a/src/actions/miscellaneous-actions.js b/src/actions/miscellaneous-actions.js
diff --git a/src/actions/network-actions.js b/src/actions/network-actions.js
@@ -19,34 +19,24 @@ import {
     getConnected, getHostname,
 } from "../apis/network.js";
 
-import { setCriticalErrorAction } from "./miscellaneous-actions.js";
-
 export const getConnectedAction = () => {
     return async (dispatch) => {
-        try {
-            const connected = await getConnected();
+        const connected = await getConnected();
 
-            return dispatch({
-                payload: { connected },
-                type: "GET_NETWORK_CONNECTED"
-            });
-        } catch (error) {
-            setCriticalErrorAction(error);
-        }
+        return dispatch({
+            payload: { connected },
+            type: "GET_NETWORK_CONNECTED"
+        });
     };
 };
 
 export const getHostnameAction = () => {
     return async (dispatch) => {
-        try {
-            const hostname = await getHostname();
+        const hostname = await getHostname();
 
-            return dispatch({
-                payload: { hostname },
-                type: "GET_NETWORK_HOSTNAME"
-            });
-        } catch (error) {
-            setCriticalErrorAction(error);
-        }
+        return dispatch({
+            payload: { hostname },
+            type: "GET_NETWORK_HOSTNAME"
+        });
     };
 };
diff --git a/src/actions/runtime-actions.js b/src/actions/runtime-actions.js
@@ -19,19 +19,13 @@ import {
     getPasswordPolicies,
 } from "../apis/runtime.js";
 
-import { setCriticalErrorAction } from "./miscellaneous-actions.js";
-
 export const getPasswordPoliciesAction = () => {
     return async (dispatch) => {
-        try {
-            const passwordPolicies = await getPasswordPolicies();
+        const passwordPolicies = await getPasswordPolicies();
 
-            return dispatch({
-                payload: { passwordPolicies },
-                type: "GET_RUNTIME_PASSWORD_POLICIES"
-            });
-        } catch (error) {
-            setCriticalErrorAction(error);
-        }
+        return dispatch({
+            payload: { passwordPolicies },
+            type: "GET_RUNTIME_PASSWORD_POLICIES"
+        });
     };
 };