Home reuse #424
Merged
Home reuse #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rvykydal
force-pushed
the
home-reuse-poc
branch
2 times, most recently
from
3c355d7
to
60543b5
Compare
5 tasks
rvykydal
force-pushed
the
home-reuse-poc
branch
14 times, most recently
from
6a25554
to
331167f
Compare
KKoukiou
reviewed
Sep 16, 2024
| request === undefined || request.reformat | ||
| ? (format ? cockpit.format(_("format as $0"), format) : null) | ||
| : ((format === "biosboot") ? format : _("mount")) | ||
| ); | ||
| // FIXME use better JS |
There was a problem hiding this comment.
It's indeed weird to do the inline conditional and then do the if conditional to possibly overwrite it.
Since we have many conditions here, let's do them all in if clauses.
src/components/storage/Common.jsx
Outdated
| await partitioningSetHomeReuse({ partitioning: part }); | ||
| } | ||
|
|
||
| if (currentPartitioning?.method === method && method === "AUTOMATIC" && storageScenarioId !== "home-reuse" && currentPartitioning.requests[0].encrypted) { |
There was a problem hiding this comment.
Can you do a multiliner with this please?
It's too long now.
test/check-storage-home-reuse
Outdated
| @@ -0,0 +1,96 @@ | |||
| #!/usr/bin/python3 | |||
| # | |||
| # Copyright (C) 2022 Red Hat, Inc. | |||
KKoukiou
reviewed
Sep 16, 2024
rvykydal
force-pushed
the
home-reuse-poc
branch
2 times, most recently
from
d29850e
to
a6fdba8
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
from
a6fdba8
to
ea37d72
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
2 times, most recently
from
3793dc9
to
953a65b
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
from
953a65b
to
08884e3
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
from
da30268
to
e4a42dc
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
4 times, most recently
from
03ce162
to
e8cf85e
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
from
e8cf85e
to
7215218
Compare
rvykydal
force-pushed
the
home-reuse-poc
branch
3 times, most recently
from
c1cf475
to
21fc223
Compare
…kend Use generic "bootloader"
Patch by Katerina Koukiou, thank you.
Follow the design mockups
KKoukiou
force-pushed
the
home-reuse-poc
branch
from
21fc223
to
de613e5
Compare
|
Did a clean rebase for the test fixes to get in the git history of this. |
KKoukiou
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires rhinstaller/anaconda#5814
TODO:
TestStorage.testLocalStandardDisks. OTOH if we hided the option if not available we would require pixel test on its own)