storage: move 'Modify storage' to the header kebab #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
modify-storage-header-move
branch
from
9995d79
to
64de977
Compare
KKoukiou
force-pushed
the
modify-storage-header-move
branch
from
64de977
to
2ae7660
Compare
|
@KKoukiou I've played with the patch in my local VM and hit an issue when I
|
Merge CockpitStorageIntegration and ModifyStorage files into one, having the "Modify storage" button split from the cockpit integration page implementation was slightly weird. Also stop utilizing the 'isFormDisabled' in the CockpitStorageIntegration, we don't disable the form anyhow from within cockpit-storage mode, so this was causing unnecessary complexity in the code.
…in mount point assignment
KKoukiou
force-pushed
the
modify-storage-header-move
branch
from
2ae7660
to
09a293e
Compare
Not sure if this bug is related to this PR (probably not) but I found what the issue was and sent two commits on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge CockpitStorageIntegration and ModifyStorage files into one, having the "Modify storage" button split from the cockpit integration page implementation was slightly weird.
Also stop utilizing the 'isFormDisabled' in the
CockpitStorageIntegration, we don't disable the form anyhow from within cockpit-storage mode, so this was causing unnecessary complexity in the code.
Related to: https://issues.redhat.com/browse/INSTALLER-3972