Skip to content

Commit

Permalink
Merge pull request #5813 from jkonecny12/master-fix-iso-test-scripts
Browse files Browse the repository at this point in the history
Fix `rebuild_iso` and `update_iso` scripts
  • Loading branch information
jkonecny12 committed Aug 12, 2024
2 parents 9c65d09 + f393b54 commit a719a9f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ tests/*.trs
tests/.coverage.*
tests/pylint/.pylint.d
tests/test-suite.log*
updates/
updates.img
dracut/dd/dd_extract
dracut/dd/dd_list
Expand Down
1 change: 1 addition & 0 deletions .structure-config
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ INFRASTRUCTURE_FILES=(
.coveragerc
.shellcheckrc
.github/
.gitignore
dockerfile/
scripts/testing/
scripts/jinja-render
Expand Down
6 changes: 2 additions & 4 deletions scripts/testing/rebuild_iso
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ EOF

BOOT_ISO="result/iso/boot.iso"
PACKAGES_DIR="result/build/01-rpm-build/"
UPDATED_BOOT_ISO="result/iso/iso.git_rev"
BOOT_ISO_GIT_REVISION="result/iso/boot.iso.git_rev"
BOOT_ISO_GIT_REVISION="result/iso/iso.git_rev"

BUILD_TARGET="boot.iso"

Expand All @@ -55,12 +54,11 @@ sudo true
# remove any previous package and relevant iso artifacts
rm -rf result/build/
rm -f ${BOOT_ISO}
rm -f ${UPDATED_BOOT_ISO}
rm -f ${BOOT_ISO_GIT_REVISION}
# make sure the iso folder actually exists
mkdir -p result/iso/
# note the Git revision from which we build the boot.iso
git rev-parse HEAD > result/iso/boot.iso.git_rev
git rev-parse HEAD > ${BOOT_ISO_GIT_REVISION}

# build the anaconda rpms
make -f ./Makefile.am container-rpms-scratch
Expand Down
2 changes: 1 addition & 1 deletion scripts/testing/update_iso
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def make_updates_image(git_id, rpm_paths):
# Create the necessary folder structure
os.makedirs(UPDATES_FOLDER, exist_ok=True)
# Prepare updates image
cmd = f"./scripts/makeupdates -k -c -t {git_id}{rpm_args}"
cmd = f"./scripts/makeupdates -c -t {git_id}{rpm_args}"
print("** Calling:", cmd)
os.system(cmd)
# Move it next to the ISOs
Expand Down

0 comments on commit a719a9f

Please sign in to comment.