-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: adding PRETTY_NAME to use in title instead of anaconda generic title #4830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixups needed. Also tests :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change!
There's a minor difference what what I intended: I was thinking of having the full distribution name + version at the top and the welcome to message only have the distribution name (without version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
-
I'm not sure this is the right place where the data should come from. Take a look atSorry, I see this is proposed to be done like this. In that case it's fine.pyanaconda/product.py
- that loads/.buildstamp
and environment variables. This should work similarly, in fact we already getisFinal
from buildstamp inbetanag.js
. -
I don't think
conf.js
is the right place for the helper. That file contains the custom parser for anaconda config, which is a pretty specific thing. Maybe some other helper with things for the "product" information?Maybe some reorganization is in order, so that the betanag stuff and anything else reading buildstamp are together?
Apart from that, this looks good to me.
@garrett it would like this: |
894d3f4
to
88504b5
Compare
5cb9ea9
to
ec8b796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't include merge commits and/or empty commits in your PRs.
58d660d
to
61020e6
Compare
/kickstart-test --waive webui only |
392e9ee
to
ae39a5b
Compare
@acruzgon: That looks good!
No, we don't need to. It would fit right in with Fedora, but would probably be a bit much in the context of RHEL and CentOS. |
/kickstart-test --waive webui only |
According to UX, "Anaconda" should never show to people to avoid confusion. This PR is to start using
PRETTY_NAME
instead of the generic Anaconda title.Before:
After: