Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build of anaconda-iso-creator autobuild (#infra) #4840

Conversation

jkonecny12
Copy link
Member

Autobuild container image for building of the ISO.

This is just a small draft quickly created to find out if we want to have such a thing.

Question to answer are we fine to have this without tests? The issue with running the build test is that you need to have KVM access which means not a GH runners.

Autobuild container image for building of the ISO.
@jkonecny12 jkonecny12 marked this pull request as draft June 17, 2023 14:07
@github-actions github-actions bot added f39 infrastructure Changes affecting mostly infrastructure labels Jun 17, 2023
@VladimirSlavik
Copy link
Contributor

There are no tests to run in the container, I think, so no problem not running them :)

However - why? The reason I ask is that the daily release rehearsals ("try release daily") build the container and actually use it, on all 3 main branches, so it's verified to be functional or raise an alarm.

If it's to maybe also push the container for master, that sounds like a good thing to try.

@jkonecny12
Copy link
Member Author

That is great idea!

To answer the why question. Having this will simplify building of the images and make those more accessible. If you look on the discussion happening yesterday, people are confused that it's starting the download of the image and fail.

@M4rtinK
Copy link
Contributor

M4rtinK commented Jun 20, 2023

To answer the why question. Having this will simplify building of the images and make those more accessible. If you look on the discussion happening yesterday, people are confused that it's starting the download of the image and fail.

Yeah, that was super confusing - I was just following the docs & hit it right away. :P Nice to see this being addressed. :)

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :)

@VladimirSlavik
Copy link
Contributor

VladimirSlavik commented Jun 21, 2023

Maybe consider pushing the container after the release test instead? I mean, in the other workflow...

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 21, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f39 infrastructure Changes affecting mostly infrastructure stale
Development

Successfully merging this pull request may close these issues.

3 participants