Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "WebUI: explicitly specify GITHUB_BASE for pixel test commands" #4841

Merged

Conversation

KKoukiou
Copy link
Contributor

This reverts commit dc9b3a5.

When pulling pixel test references with the full link GITHUB_BASE is not needed. This would be needed if we would use only the PR number.

This reverts commit dc9b3a5.

When pulling pixel test references with the full link GITHUB_BASE is not
needed. This would be needed if we would use only the PR number.
Copy link
Contributor

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is correct, but it also doesn't hurt very much.

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui only

@KKoukiou KKoukiou merged commit 70a2a21 into rhinstaller:master Jun 19, 2023
13 checks passed
@KKoukiou KKoukiou deleted the webui-github-base-only-when-pushing branch June 19, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants