Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Change help drawer width #4866

Merged
merged 1 commit into from
Jun 28, 2023
Merged

WebUI: Change help drawer width #4866

merged 1 commit into from
Jun 28, 2023

Conversation

OndrejZobal
Copy link
Contributor

  • Set max width to half of viewport,
  • increase minimal width to prevent the
    "x" button being pushed by the help title,
  • convert default size to rem.

@OndrejZobal
WebUI: Change help drawer width
3f88f0b 
- Set max width to half of viewport,
- increase minimal width to prevent the
  "x" button being pushed by the help title,
- convert default size to rem.
@KKoukiou
Copy link
Contributor

/kickstart-test --waive webui only

KKoukiou
KKoukiou approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go away with garrets new designs i think, but the change looks fine.

We also need to unify this help drawer with the ones from storage configuration page

@KKoukiou KKoukiou merged commit 6f34f4c into rhinstaller:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OndrejZobal @KKoukiou