webui: tests: switch some storage tests to nondestructive #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
webui-non-destructive-tests
branch
2 times, most recently
from
b20c192
to
b1a6540
Compare
KKoukiou
force-pushed
the
webui-non-destructive-tests
branch
2 times, most recently
from
4ab826d
to
42451b1
Compare
jelly
approved these changes
Jul 10, 2023
KKoukiou
force-pushed
the
webui-non-destructive-tests
branch
from
42451b1
to
a898673
Compare
VladimirSlavik
approved these changes
Jul 10, 2023
M4rtinK
approved these changes
Jul 11, 2023
|
|
||
| class VirtInstallMachineCase(MachineCase): | ||
| MachineCase.machine_class = VirtInstallMachine | ||
|
|
||
| def setUp(self): | ||
| # FIXME: running this in destructive tests fails because the SSH session closes before this is run | ||
| if self.is_nondestructive(): | ||
| self.addCleanup(self.rescanStorage) |
There was a problem hiding this comment.
Maybe we could print/log a warning when someone calls this by mistake in destructive mode ?
There was a problem hiding this comment.
Hmm i don't see how I can know if rescanStorage will be added with an addCleanup in the future
KKoukiou
force-pushed
the
webui-non-destructive-tests
branch
3 times, most recently
from
10cd471
to
36b195d
Compare
|
/webui-test |
|
Permian tests are failing https://github.com/rhinstaller/anaconda/actions/runs/5541527226 |
For the two tests affected in this commit it was enough to use add_ram_disk test storage helper, which has includes a teardown cleanup.
KKoukiou
force-pushed
the
webui-non-destructive-tests
branch
from
36b195d
to
3d84a10
Compare
|
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the two tests affected in this commit it was enough to use add_ram_disk test storage helper, which has includes a teardown cleanup.