Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "webui: pin down cockpit-* packages versions for gating purposes" #4887

Closed
wants to merge 1 commit into from
Closed

Revert "webui: pin down cockpit-* packages versions for gating purposes" #4887

wants to merge 1 commit into from

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Jul 7, 2023

No description provided.

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Jul 10, 2023
@VladimirSlavik
Copy link
Contributor

It would be kind of nice to the rest of the team to note here what this really is - the counterpart to #4885 for when things work again. What does it mean, work again? Nobody knows. Instead we get No description provided and have to read the internal chat to maybe find out some bits of this...

@KKoukiou
Copy link
Contributor Author

It would be kind of nice to the rest of the team to note here what this really is - the counterpart to #4885 for when things work again. What does it mean, work again? Nobody knows. Instead we get No description provided and have to read the internal chat to maybe find out some bits of this...

I don't think you will find any information in the internal chat, as nobody aside from me was working when this broke CI.
All the information that are available is in the original PR commit (the PR that this one reverts).

@KKoukiou KKoukiou force-pushed the reproduceable-updates-img-revert branch from 02274f1 to 754e9d6 Compare July 11, 2023 14:20
@KKoukiou KKoukiou force-pushed the reproduceable-updates-img-revert branch from 754e9d6 to fbfc1fa Compare July 19, 2023 07:51
@KKoukiou KKoukiou removed the blocked Don't merge this pull request! label Jul 20, 2023
@KKoukiou KKoukiou force-pushed the reproduceable-updates-img-revert branch from fbfc1fa to 0b29e3f Compare July 26, 2023 16:30
@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Jul 27, 2023
@KKoukiou
Copy link
Contributor Author

Actually I don't want to revert this - because having these gated is the only way we can ensure stable CI. And exactly this two lines have broken us at least once the past month.

In 1 month with f39 release the webui dependencies will be inside the isos, and the cockpit deps will not need to be installed separately.

@KKoukiou KKoukiou closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
blocked Don't merge this pull request! f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKoukiou @VladimirSlavik @jkonecny12