Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: tests: implement a 'reach' helper method #4902

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

KKoukiou
Copy link
Contributor

This allows us in the tests to reach a desired page with one test function call, instead of calling 'next' all the time.

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui only

@KKoukiou KKoukiou marked this pull request as ready for review July 11, 2023 13:29
@KKoukiou KKoukiou requested a review from M4rtinK July 11, 2023 13:29
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - a very nice improvement, thanks! :)

This allows us in the tests to reach a desired page with one test
function call, instead of calling 'next' all the time.
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui-tests only

@KKoukiou KKoukiou merged commit e6332a9 into rhinstaller:master Jul 11, 2023
@KKoukiou KKoukiou deleted the webui-test-next-dfs branch July 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants