Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: new design for the storage entry page #4922

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@garrett
Copy link

garrett commented Jul 18, 2023

/boot-iso --webui

@KKoukiou KKoukiou force-pushed the webui-redesign branch 3 times, most recently from 697ab86 to 218daa2 Compare July 20, 2023 15:31
@KKoukiou KKoukiou marked this pull request as ready for review July 20, 2023 15:35
@KKoukiou KKoukiou changed the title webui: new design for welcome page in live image webui: new design for the storage entry page Jul 20, 2023
@KKoukiou KKoukiou requested a review from garrett July 20, 2023 15:38
@jkonecny12
Copy link
Member

/boot-iso --webui

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Re-approach the installation method and target screen, by merging these
into one single step acting as first step in the live os media.

Remove all helper drawers and put the compact re-formated text inline.

testStoragePartitions was deleted as it's now obsolete. It was testing
the local disks table rows expanded content.
@jkonecny12
Copy link
Member

/boot-iso --webui

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from the design PoV.
I checked the code briefly and looks good to me too as far as understand :).

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui only

@KKoukiou KKoukiou removed the request for review from garrett July 24, 2023 13:13
@KKoukiou KKoukiou merged commit 11dc7d0 into rhinstaller:master Jul 24, 2023
14 checks passed
@KKoukiou KKoukiou deleted the webui-redesign branch July 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants