webui: tests: extend the TestInstallationProgress test to include reboot #4981
Conversation
|
https://access.redhat.com/solutions/41976 might be a solution for our non-working rebooting |
KKoukiou
changed the title
KKoukiou
force-pushed
the
allow-reboot
branch
2 times, most recently
from
98128e9
to
a147a2d
Compare
There was a problem hiding this comment.
@martinpitt can you help me with the last remaining test failure here?
The problem is that if they installation fails, and we reboot the machine, the destination disk is unbootable, and the test fails on teardown because of broken ssh connection.
Is there a way to tell the test to skip teardown maybe?
|
Don't end to end test already support & perform machine reboot & simple booted system testing ? I am a bit confused on which level this testing flow works so that it adds another implementation of the reboot logic. Could it be perhaps shared with what the end-to-end tests use ? :) |
This is already shared with what e2e tests use. The the helper file moved from the e2e tests direcotyr to the shared folder. |
Not right now. You have to modify testlib.py to support some "expect broken machine" flag in MachineCase, which you can set inside a test. Then tearDown() could check that flag and skip the explicit cleanup. However, that won't help for the staged things to addCleanup(), for that you'd need to rummage in unittest.TestCase's guts to delete the handler list. Would it perhaps be easier to avoid the situation by not rebooting the VM in tests where it's known and expected to fail anyway? |
For making this possible add `--wait` option to virt-install invocation [0]. This now allows the VM to reboot when reboot is requested, whilst previously it was just shutting down. [0] https://listman.redhat.com/archives/virt-tools-list/2011-November/002869.html Now that the VM reboots when reboot is requests it's not possible to test the "Quit" button as on boot.iso the Quit button actually reboots the VM into the unbootable disk (as the installation did not finish). The later state will fail the test teardown, as the target VM is not reachable. Therefore the tests checking the 'Quit' button were removed. Co-authored-by: Katerina Koukiou <kkoukiou@redhat.com>
|
/kickstart-test --waive webui-only |
No description provided.