webui: fix logic for when to re-create the partitioning #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
webui-fix-custom-part-recreate
branch
from
56454f5
to
5407b89
Compare
KKoukiou
changed the title
KKoukiou
changed the title
|
I did just a quick test with this change and it looks like the mount point assignment is stuck in an infinite loop upon entering -- logs show the copy of the storage model and manual partitioning are being created over nad over again. |
Interesting - I see it also in the test, will check again. Sorry |
KKoukiou
force-pushed
the
webui-fix-custom-part-recreate
branch
2 times, most recently
from
65dfcc3
to
6972f56
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKoukiou
force-pushed
the
webui-fix-custom-part-recreate
branch
from
6972f56
to
97604a7
Compare
KKoukiou
force-pushed
the
webui-fix-custom-part-recreate
branch
2 times, most recently
from
194ea69
to
ebec5a4
Compare
Now partitioning is marked for re-creation when device selection changes and when the user re-scans the device tree. The latter invalidates the partitioning indirectly, by re-setting the selected devices. This commit also simplifies the partitioning object update in state, as a clean state update was needed to make the above feature work as expected.
KKoukiou
force-pushed
the
webui-fix-custom-part-recreate
branch
from
ebec5a4
to
63fa26a
Compare
|
/kickstart-test --waive webui only |
KKoukiou
added a commit
to KKoukiou/anaconda
that referenced
this pull request
Aug 8, 2023
…rt-recreate webui: fix logic for when to re-create the partitioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.