make: Update POT file correctly #5014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4rtinK
approved these changes
Aug 7, 2023
The changes from 70d7814 should not have been applied to the top level makefile.
VladimirSlavik
force-pushed
the
master-pot-update-fix
branch
from
b4f6286
to
890a4db
Compare
|
Good that I did not merge it, I just realized the fix was wrong. We want to put the new pot on the branch, not on top of the pinned commit. The top level makefile needed "reverting", not doing the same as the subdir one getting actual translations. |
|
/kickstart-test --testtype smoke edit: Looks like it's crashing on unreachable repo. Branching is here! |
VladimirSlavik
changed the title
|
/kickstart-test --waive infra only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from 70d7814 were mistakenly applied to the top level makefile.
Needed to fix the daily pot file updates in l10n repo: https://github.com/rhinstaller/anaconda-l10n/actions/workflows/pot-file-update.yaml