-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: introduce a button to launch blivet GUI #5017
Conversation
This is available only for live images.
I am not able to build the live ISO (too few resources) so I cant test this. @M4rtinK @jkonecny12 can one of you build this for me? |
Here is link to your ISO: https://drive.google.com/file/d/1QY_HIyQNDohPYpo7ZKJBB8mqnqk2yFIJ/view?usp=sharing |
Please add a screenshot of how it looks like. :) |
Why can't I see it when it is launched? |
@VladimirSlavik can you check again please? I can see it. |
Hmm i think it depends if the window is full screen. I see in the journal when it fails: meta_window_set_stack_position_no_sync assertion 'window- stack_position = 0' failed Update: so I confirm that when the firefox is taking the full screen launcing the blivet app will fail with the error above. Ths is an unresolved bug https://gitlab.gnome.org/GNOME/mutter/-/issues/930 |
Interesting, blivet-gui correctly starts in the foreground when Anaconda was launched from the Welcome to Fedora window. If I launch Anaconda from the launcher blivet-gui always starts in the background, even if the Firefox window is not maximized. Also noteworthy is that some applications start in the foreground and some not (when starting Anaconda from the launcher): blivet-gui and Eye of GNOME start in the background, Nautilus and GNOME Weather start in the foreground. I'll try to look into this some more, maybe there's something I can do on the blivet-gui side to make sure it is always started in the foreground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The issue with blivet-gui starting in the background will be most likely fixed in GNOME or blivet-gui itself so I don't think it should block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, then this is fine.
/kickstart-test --waive webui-only |
This is available only for live images.