Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: introduce a button to launch blivet GUI #5017

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Aug 7, 2023

This is available only for live images.
modify-storage

This is available only for live images.
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Aug 7, 2023

I am not able to build the live ISO (too few resources) so I cant test this.

@M4rtinK @jkonecny12 can one of you build this for me?

@jkonecny12
Copy link
Member

@M4rtinK
Copy link
Contributor

M4rtinK commented Aug 8, 2023

Please add a screenshot of how it looks like. :)

@VladimirSlavik
Copy link
Contributor

Why can't I see it when it is launched?

@KKoukiou KKoukiou marked this pull request as draft August 8, 2023 13:04
@KKoukiou KKoukiou marked this pull request as ready for review August 8, 2023 15:15
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Aug 8, 2023

Why can't I see it when it is launched?

@VladimirSlavik can you check again please? I can see it.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Aug 8, 2023

Why can't I see it when it is launched?

@VladimirSlavik can you check again please? I can see it.

Hmm i think it depends if the window is full screen. I see in the journal when it fails: meta_window_set_stack_position_no_sync assertion 'window- stack_position = 0' failed

Update: so I confirm that when the firefox is taking the full screen launcing the blivet app will fail with the error above. Ths is an unresolved bug https://gitlab.gnome.org/GNOME/mutter/-/issues/930

@vojtechtrefny
Copy link
Contributor

Interesting, blivet-gui correctly starts in the foreground when Anaconda was launched from the Welcome to Fedora window. If I launch Anaconda from the launcher blivet-gui always starts in the background, even if the Firefox window is not maximized.

Also noteworthy is that some applications start in the foreground and some not (when starting Anaconda from the launcher): blivet-gui and Eye of GNOME start in the background, Nautilus and GNOME Weather start in the foreground. I'll try to look into this some more, maybe there's something I can do on the blivet-gui side to make sure it is always started in the foreground.

Copy link
Contributor

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The issue with blivet-gui starting in the background will be most likely fixed in GNOME or blivet-gui itself so I don't think it should block this PR.

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, then this is fine.

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui-only

@KKoukiou KKoukiou merged commit ecadc8b into rhinstaller:master Aug 10, 2023
13 checks passed
@KKoukiou KKoukiou deleted the blivet-gui-button branch August 10, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants