webui: Back/Next button are not localized

[adamkankovsky]

Replacing back-ticks with cockpit.format due to a translation error in response to @VladimirSlavik comment in issue https://issues.redhat.com/browse/INSTALLER-3601?focusedId=22756092&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22756092

[KKoukiou]

Please link the Jira issue comment from vladimir which justifies this change.

[VladimirSlavik]

I'll just copy the comment here into the open. Oh, and it might make sense to have it in the commit too.

The root cause appears to be a bug in xgettext: http://savannah.gnu.org/bugs/?50920 Apparently, mixing the JSX pointy bracket block and js template string (`with backticks`) causes the xgettext parser to seize and exit prematurely for the whole file.

In our case, this can be observed by finding any such template string inside JSX and checking our POT file (in anaconda-l10n repo!) that no translateable strings found below this are present. Example strings (as of writing this): "Next", "Select a disk".

The upstream bug remains open and accordingly manifests in our infra which uses fedora rawhide. We need to work around this by not using such constructs.

It's really sad, the bug started in 2017, last activity is in 2020, and there is no clear resolution. Perhaps it's because JSX is not standardized.

[VladimirSlavik]

Just to have it written down - Somehow the C parser works for JSX, and also does not crash on the syntax that Javascript parser does. This is what Cockpit uses, although it's hard to find how this happened.

So all this needed was changing the one option and commenting it so that we know.

[VladimirSlavik]

Thank you!

[KKoukiou]

/kickstart-test --waive webui-only