webui: fix make rsync not updating the test VM

[KKoukiou]

make rsync stores the new files in /usr/local/share/cockpit whilst the original files are in /usr/share/cockpit.

So the running session doesn't recognize the new
directory in /usr/local/, that'd require a bridge restart.

This is not possible to do as that makes anaconda think that user Quit the installation.

[M4rtinK]

Looks good to me - if it fixes the current breakage, I'm fine with merging this.

[M4rtinK]

make rsync stores the new files in /usr/local/share/cockpit whilst the original files are in /usr/share/cockpit.

Can't we make it so, that make rsync syncs into /usr/share/cockpit & overwrites the files there ?

Looks like the target path is controlled by this cockcpit maintained plugin: https://github.com/cockpit-project/cockpit/blob/c865f6a578c9039a82b2417f9fe559293b81d407/pkg/lib/cockpit-rsync-plugin.js#L41

So I guess we could teach the plugin to make the path configurable & set it in out build.js file ?

[KKoukiou]

make rsync stores the new files in /usr/local/share/cockpit whilst the original files are in /usr/share/cockpit.

Can't we make it so, that make rsync syncs into /usr/share/cockpit & overwrites the files there ?

Looks like the target path is controlled by this cockcpit maintained plugin: https://github.com/cockpit-project/cockpit/blob/c865f6a578c9039a82b2417f9fe559293b81d407/pkg/lib/cockpit-rsync-plugin.js#L41

So I guess we could teach the plugin to make the path configurable & set it in out build.js file ?

sure but that will need change to cockpit repository. Can be follwup improvement?

[M4rtinK]

sure but that will need change to cockpit repository. Can be follwup improvement?

Sure, I'm fine with this PR being a quick fix & proper solution being implemented as a followup. I'll also create a Jira issue to track the followup.

[KKoukiou]

/kickstart-test --waive webui-only

[KKoukiou]

The rest of failures are unrelated (dnf5 revert)