Swap support for mount point assignment #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually, you don't want to change something that comes before with something that comes later (that is, elements that are to the left (in LTR, but right in RTL) and above), but I guess in this case, it makes sense. Also, unrelated: This screenshot shows there's a lot of space between the reformat and trash/remove icon... I guess we should fix the layout and how it expands (in another PR). |
KKoukiou
approved these changes
Aug 14, 2023
|
/kickstart-test --testtype smoke |
vojtechtrefny
force-pushed
the
master_mountpoint-assignment-swap
branch
from
a1f2eb3
to
158fb8b
Compare
We don't need to reformat swap partition to be able to reuse it and when swap is shared between multiple systems reformatting it would change its UUID potentially breaking the other system(s) we are dualbooting with.
Swap devices are not really mountable, but we need to somehow indicate that the device will be used in the installed system and written into /etc/fstab. For that we currenly use "swap" mount point both in TUI mount point assignment and in Custom Spoke. For WebUI we'll prefill the mount point for all selected devices formatted to "swap".
vojtechtrefny
force-pushed
the
master_mountpoint-assignment-swap
branch
from
158fb8b
to
5ee3ae4
Compare
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that when user selects a device formatted as swap we'll automatically set mount point to swap and disable the input field. Also swap devices can now be reused without reformatting (there's no reason to force reformatting and there are situation where it could cause issues).
(On the screenshot, both vda2 and vda3 are preformatted as swap.)