Don't directly copy webui files in makeupdates script #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we tried to copy webui files directly when creating an updates image, like we do with our python, glade, C and other files. But eventually it turned out to be easier to builds the RPMs and then include those into the updates image instead. But the original code was still in place, causing issues such as causing an unexpected attempt to start the Web UI when trying to change something in the Anaconda text interface. So lets drop the direct copy of the webui files from the makeupdates script, at least for now. This should not influence the current Web UI workflow, which already works with RPMs exclusively & should avoid issues when makeupdates is used in non-Web-UI use cases.
VladimirSlavik
approved these changes
Aug 11, 2023
vojtechtrefny
approved these changes
Aug 11, 2023
KKoukiou
approved these changes
Aug 14, 2023
|
/kickstart-test --testtype smoke |
rvykydal
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we tried to copy webui files directly when creating an updates image, like we do with our python, glade, C and other files.
But eventually it turned out to be easier to builds the RPMs and then include those into the updates image instead.
But the original code was still in place, causing issues such as causing an unexpected attempt to start the Web UI when trying to change something in the Anaconda text interface.
So lets drop the direct copy of the webui files from the makeupdates script, at least for now.
This should not influence the current Web UI workflow, which already works with RPMs exclusively & should avoid issues when makeupdates is used in non-Web-UI use cases.