Improve build of the ISO creating containers #5052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
force-pushed
the
master-fix-root-owning-files-after-iso-build
branch
from
61f2e83
to
b51b643
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! CONTRIBUTING.rst |
|
Please split the PR according to what you are fixing or changing. Owner after image build = one thing. Caching = second thing. Dependencies = third thing. |
jkonecny12
changed the title
|
Looks like without weak deps, the tests don't succeed. |
|
/kickstart-test --testtype smoke |
Do not require people to use any Makefile commands as sudo. The sudo calls should be solved inside of the Makefile.
Because the build of an ISO is done as root the output artifacts are root too. To solve this copy the ownership from the input anaconda RPMs to the output artifacts.
jkonecny12
force-pushed
the
master-fix-root-owning-files-after-iso-build
branch
from
b51b643
to
2cb2b61
Compare
|
Infrastructure check failed on these files. Please do a double check of these files before merge! CONTRIBUTING.rst |
|
/kickstart-test --testtype smoke |
jkonecny12
changed the title
VladimirSlavik
approved these changes
Aug 23, 2023
|
Should be good to merge, I'll change the build action in #5071 as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ownership of the artifacts build from the ISO builds
The ISO builds are required to be done under root. That means that the resulting artifacts are also root owned. That makes troubles with
git cleanor similar calls. To solve that copy theownerandgroupfrom the input Anaconda RPMs to output artifacts. That should be correct most of the time.Also remove requirements to run make commands as root
The
sudo make ...is just wrong and should not be used anymore. Insteadsudocalls are abstracted in theMakefile.Improve usage of the container build cache
Cache could save a lot of time during development but could cause outdated images because container don't know if the DNF call is outdated. To resolve this with a compromise let's set the cache live to246 hours. When cache is older than246 hours it will be ignored otherwise it's used.This is significant improvement to container development!
Moved to #5073
Reduce size of the images
For all the DNF calls disable weak dependencies.This is harder to test but should be easily to fix potential issues.
However, the saving should be nice. In my simple testing:
anaconda-ci on master branch:original size: 2.68 GiB
new size: 2.22 GiB
Moved to #5072
Improve the documentation of the ISO builds
Reflect new changes.
Improve the state based on the feedback I've got.