/boot/efi support for mount point assignment #5066
Conversation
vojtechtrefny
force-pushed
the
master_uefi-support
branch
5 times, most recently
from
f184584
to
c68eb4e
Compare
vojtechtrefny
force-pushed
the
master_uefi-support
branch
from
c68eb4e
to
6edf0fd
Compare
|
oof. this seems really kinda inelegant. don't we already have a whole bunch of code for figuring out what mount points are required for what platforms and so on? why are we recreating this ad hoc in the webUI front end code? Aren't there special requirements on powerpc? We do produce a Workstation live image for PowerPC: do we now have to add more ad hoc recreations of the powerpc boot partition requirements too? |
|
Filed https://bugzilla.redhat.com/show_bug.cgi?id=2234967 as an F39 Beta FE bug. |
The code for required mount points lives in the backend and was never needed in the front end so making it available in the WebUI will require more work. I plan to do this the right way, but it will take more time. This is definitely an ugly hack, but I wanted to have this in the WebUI as soon as possible. You'll get an error before starting the installation about missing |
vojtechtrefny
force-pushed
the
master_uefi-support
branch
3 times, most recently
from
cce96e9
to
c73360d
Compare
|
JIRA tracking: https://issues.redhat.com/browse/INSTALLER-3662 |
vojtechtrefny
force-pushed
the
master_uefi-support
branch
from
c73360d
to
4f4d549
Compare
|
/kickstart-test --testtype smoke |
Just a hack with checking /sys/firmaware/efi, we need a backend function to make this properly.
vojtechtrefny
force-pushed
the
master_uefi-support
branch
from
4f4d549
to
2817d02
Compare
|
/kickstart-test --waive webui only |
|
This does not fully fix the problem. It fixes it on only the first trip through the mount point assignment screen. If you contrive to return to it - e.g. by clicking Back then Next, or clicking Installation method on the left and proceeding to Mount point assignment again - /boot/efi never again shows up as Required. |
I've created #5121 which should fix this and also does gets the mountpoints from the backend instead of manually checking |
This makes sure
/boot/efiis added to required mount points on EFI systems and adds an check to make sure it is mounted on a correct device/format.I also added support for creating a EFI VM for the tests, I am not 100 % sure this will work in CI so creating this as a draft for now.