Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard length of url for bz reporting #5067

Merged

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Aug 22, 2023

Low priority, the first commit can be perhaps merged separately.
https://issues.redhat.com/browse/INSTALLER-3612

Example of truncated comment:
(The message should appear really exceptionally - we don't expect automatically generated Detail/comment to exceed the 7000 characters. It is there so it is clear what really happened (the comment was truncated) in such a rare case.)

Screenshot from 2023-08-22 14-34-38

@rvykydal rvykydal added master Please, use the `f39` label instead. f40 labels Aug 22, 2023
@rvykydal rvykydal marked this pull request as draft August 22, 2023 15:22
@rvykydal rvykydal force-pushed the guard-length-of-url-for-bz-reporting branch 2 times, most recently from 8a821d5 to e62415f Compare August 23, 2023 07:56
@rvykydal
Copy link
Contributor Author

/kickstart-test --waive webui-only

@rvykydal rvykydal marked this pull request as ready for review August 23, 2023 09:54
@VladimirSlavik
Copy link
Contributor

VladimirSlavik commented Aug 24, 2023

/webui-test

Sorry, I need to see the status name to enforce it...

@rvykydal rvykydal force-pushed the guard-length-of-url-for-bz-reporting branch from e62415f to 65925a9 Compare August 28, 2023 14:53
@rvykydal rvykydal force-pushed the guard-length-of-url-for-bz-reporting branch from 65925a9 to 9ce0c38 Compare September 5, 2023 13:32
@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 5, 2023

So I added some comments in the code and removed the message informing about the Detail being cut from the Detail. The message asking to attach the log is still added after the cut detail.

Screenshot from 2023-09-05 15-29-40

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ui/webui/src/apis/storage.js Outdated Show resolved Hide resolved
@rvykydal rvykydal force-pushed the guard-length-of-url-for-bz-reporting branch from 9ce0c38 to 16236fb Compare September 6, 2023 07:03
@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 6, 2023

/kickstart-test --waive webui-only

@VladimirSlavik
Copy link
Contributor

/webui-test

@rvykydal rvykydal force-pushed the guard-length-of-url-for-bz-reporting branch from 16236fb to 4ac0e0c Compare September 11, 2023 14:28
@rvykydal
Copy link
Contributor Author

/kickstart-test --waive webui-only

@rvykydal rvykydal merged commit 902724e into rhinstaller:master Sep 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f39 f40 master Please, use the `f39` label instead. webui
Development

Successfully merging this pull request may close these issues.

3 participants