webui: Update request IDs when removing mount point row #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if this is the best way to fix this issue, but it seems to be working fine. The problem is that after removing a row which is not last we end up with a "gap" in the IDs and next row/mount point added now has the same ID as the previous one, because new IDs are allocated simply as number of requests + 1. I was thinking about changing this to last request + 1 but that also might be problematic because we also use the request ID as the row ID. Feel free to suggest a better approach. |
vojtechtrefny
force-pushed
the
master_fix-row-remove
branch
from
c81a281
to
ca13a39
Compare
jkonecny12
approved these changes
Aug 25, 2023
When removing a mount point row, we need to decrease IDs for the requests with higher IDs to avoid having duplicate ID when adding a new row. Resolves: rhbz#2232398
vojtechtrefny
force-pushed
the
master_fix-row-remove
branch
from
ca13a39
to
f96a54a
Compare
|
/kickstart-test --waive webui-only |
M4rtinK
approved these changes
Aug 28, 2023
VladimirSlavik
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a mount point row, we need to decrease IDs for the requests with higher IDs to avoid having duplicate ID when adding a new row.
Resolves: rhbz#2232398