Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the ESP maximum size back to 600MiB #5090

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Aug 28, 2023

The original issue was that 200MiB was too small, and we only increased the maximum for people experimenting with UKIs. Seeing as Anaconda chooses the maximum size in more cases than we'd like just drop the maximum size back down to 600MiB which is easily big enough for firmware updates.

This should fix several regressions like:

Signed-off-by: Richard Hughes richard@hughsie.com

Resolves: rhbz#2234951

@M4rtinK M4rtinK added the f39 label Aug 28, 2023
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 29, 2023

/kickstart-test --testtype smoke

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 29, 2023

Rawhide PR: #5081

@VladimirSlavik
Copy link
Contributor

Please update to latest version for master?

@VladimirSlavik
Copy link
Contributor

The master version has been merged with all known issues resolved. Feel free to cherry-pick afe5cef instead and it should be ok.

The original issue was that 200MiB was too small, and we only increased the
maximum for people experimenting with UKIs. Seeing as Anaconda chooses the
maximum size in more cases than we'd like just drop the maximum size back down
to 600MiB which is easily big enough for firmware updates.

This should fix several regressions like:

 * https://bugzilla.redhat.com/show_bug.cgi?id=2212121
 * https://bugzilla.redhat.com/show_bug.cgi?id=2214342

Signed-off-by: Richard Hughes <richard@hughsie.com>

cherry picked from commit afe5cef

Resolves: rhbz#2234951
Related: rhbz#2212121
Related: rhbz#2214342
Related: rhbz#2231339
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Sep 6, 2023

Updating to PR to be in sync with the version that was merged on Rawhide.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Sep 6, 2023

/kickstart-test --testtype smoke

@M4rtinK M4rtinK merged commit 063bc0a into rhinstaller:fedora-39 Sep 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants