F39 add iso build scripts to templates #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infrastructure
|
/kickstart-test --testtype smoke |
Comment on lines
1
to
8
| # ====================================== | ||
| # WARNING! | ||
| # THIS FILE IS GENERATED FROM A TEMPLATE | ||
| # DO NOT EDIT THIS FILE MANUALLY! | ||
| # ====================================== | ||
| # The template is located in: lmc-build.j2 | ||
|
|
||
| #!/bin/bash |
There was a problem hiding this comment.
This will not work, I think. The hashbang needs to be at the first line. Maybe it must be special-cased in the rendering script :-/
There was a problem hiding this comment.
Shebang handling ported to f39 in #5108 - feel free to ack+merge and rebase this on top (or not if it's wrong!).
|
Two prerequisites:
|
VladimirSlavik
approved these changes
Aug 30, 2023
jkonecny12
force-pushed
the
f39-add-iso-build-scripts-to-templates
branch
2 times, most recently
from
0468c37
to
243a6d0
Compare
|
/kickstart-test --testtype smoke |
|
UPDATED:
|
VladimirSlavik
approved these changes
Aug 31, 2023
We need to add the build scripts into our templating solution.
We need to add script and Dockerfile to our templating solution.
The j2 files are our templating and these are not usual shell scripts.
jkonecny12
force-pushed
the
f39-add-iso-build-scripts-to-templates
branch
from
243a6d0
to
2edbdae
Compare
|
/kickstart-test --testtype smoke |
VladimirSlavik
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ISO build to take branched Fedora sources instead of Rawhide.
The Live ISO builds will be broken until fedora-39-boot iso is added to Cockpit/bots repository.