webui: Fix validity state during navigation #5099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goToPage used "false" as the default, the rest are using "true". Let's standardize on "true" as the default.
Without navigation, the step component remains the same and will not be triggered into re-computing the validity state.
mvollmer
force-pushed
the
webui-valid-validity
branch
from
5c25a6a
to
79a60a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug: When clicking on the currently active step, the "Next" button is disabled and isn't enabled again until the user does sufficient changes in the page.
Concretely, when the installer starts up and shows the "Welcome" step, clicking on "Welcome" in the left column will disable "Next". Selecting a different language than the current one will enable it again.
This PR fixes that by not changing the validation state in goToPage if no navigation will actually happen.