Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar navigation - Fedora 39 version #5101

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix sidebar navigation - Fedora 39 version #5101

merged 2 commits into from
Aug 29, 2023

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Aug 29, 2023

No description provided.

@rvykydal @M4rtinK
webui: do not reset validity of step id moving to the same step (#223…
3353f4e 
…3805)

Resolves: rhbz#2233805
Related: rhbz#2231339
@rvykydal @M4rtinK
webui: add basic test for sidebar navigation (#2233805)
13c99b1 
Related: rhbz#2233805
Related: rhbz#2231339
@M4rtinK M4rtinK added the f39 label Aug 29, 2023
@github-actions github-actions bot added the webui label Aug 29, 2023
VladimirSlavik
VladimirSlavik approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Maybe link to the original, so that it's clear it's a port.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 29, 2023

/kickstart-test --waive webui only

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 29, 2023

LGTM, thank you! Maybe link to the original, so that it's clear it's a port.

Good point - original Rawhide PR is: #5084

@M4rtinK M4rtinK merged commit 2c1e8b3 into rhinstaller:fedora-39 Aug 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M4rtinK @VladimirSlavik @rvykydal