Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F39 webui pre blivet dialogs #5132

Merged

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Sep 6, 2023

Port of #5113 to fedora-39 branch.

@M4rtinK
Copy link
Contributor

M4rtinK commented Sep 6, 2023

/kickstart-test --waive webui only

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

ui/webui/src/components/storage/InstallationMethod.jsx Outdated Show resolved Hide resolved
@AdamWill
Copy link
Contributor

AdamWill commented Sep 6, 2023

Can you fix the typo I mentioned in #5113 (review) before merging this?

Blivet is a library, Blivet-gui is the name of the application run.

Also fix a typo.

https://issues.redhat.com/browse/INSTALLER-3638
Resolves: rhbz#2234448
Related: rhbz#2231339
@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 7, 2023

Can you fix the typo I mentioned in #5113 (review) before merging this?

Done, thank you for the catch.

@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 7, 2023

/kickstart-test --waive webui only

@M4rtinK M4rtinK merged commit 6e5e8f3 into rhinstaller:fedora-39 Sep 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants