-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F39 webui pre blivet dialogs #5132
Merged
M4rtinK
merged 9 commits into
rhinstaller:fedora-39
from
rvykydal:f39-webui-pre-blivet-dialogs
Sep 7, 2023
Merged
F39 webui pre blivet dialogs #5132
M4rtinK
merged 9 commits into
rhinstaller:fedora-39
from
rvykydal:f39-webui-pre-blivet-dialogs
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
/kickstart-test --waive webui only |
M4rtinK
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! :)
Can you fix the typo I mentioned in #5113 (review) before merging this? |
Blivet is a library, Blivet-gui is the name of the application run. Also fix a typo. https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
https://issues.redhat.com/browse/INSTALLER-3638 Resolves: rhbz#2234448 Related: rhbz#2231339
rvykydal
force-pushed
the
f39-webui-pre-blivet-dialogs
branch
from
September 7, 2023 06:30
5446bb6
to
1945967
Compare
Done, thank you for the catch. |
/kickstart-test --waive webui only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #5113 to fedora-39 branch.