Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd_extract: Add support for compressed kernel modules #5208

Closed
wants to merge 0 commits into from

Conversation

pjgeorg
Copy link
Contributor

@pjgeorg pjgeorg commented Sep 26, 2023

This PR adds support for handling compressed kernel modules to dd_extract. In particular for *.ko.gz, *.ko.xz, *.ko.bz2, *.ko.zst (these seem to be the common file extensions also supported by rpm macros).

These changes have already been merged to master (#5041), but I'd also like to include these in rhel-9.

@pep8speaks
Copy link

pep8speaks commented Sep 26, 2023

Hello @pjgeorg! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 295:100: E501 line too long (102 > 99 characters)
Line 297:100: E501 line too long (112 > 99 characters)

Comment last updated at 2024-09-13 10:38:14 UTC

@VladimirSlavik
Copy link
Contributor

Thanks! This will need a bit more than the PR on the process side:

  • An accompanying bug (jira?) is required.
  • @jkonecny12 to include it in planning + devel_ack
  • @jstodola for qa_ack

@pjgeorg
Copy link
Contributor Author

pjgeorg commented Sep 26, 2023

An accompanying bug is referenced in the commits. https://bugzilla.redhat.com/show_bug.cgi?id=2032638
However, this bug has been closed as "WONTFIX" and targets RHEL-8, not RHEL-9.
Can this bug be re-opened or shall I open a new bug (on jira?)?

@jstodola
Copy link
Contributor

Please, open a new Jira issue in the "RHEL" project: https://issues.redhat.com/projects/RHEL. Thanks.

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

@pjgeorg
Copy link
Contributor Author

pjgeorg commented Sep 26, 2023

Please, open a new Jira issue in the "RHEL" project: https://issues.redhat.com/projects/RHEL. Thanks.

https://issues.redhat.com/browse/RHEL-9913

Hope I entered all fields correctly. First time creating a bug on Jira since the move away from bugzilla.

Shall I update the commit message to reference this jira issue instead of the old bugzilla one? This would mean that the commit messages are different from the commits in master, but would link to the new Jira bug (which is probably required by policy).

@jkonecny12
Copy link
Member

Yes, the RHEL planning is correctly set now. Thanks for your contribution.

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Dec 26, 2023
Copy link

This PR was closed because it has been stalled for 30 days with no activity.

@jkonecny12
Copy link
Member

Hi, I wanted to rebase this PR but I accidentally pushed top of rhel-9 branch into your fork branch which automatically closed this PR with no option to reopen it. So I was forced to create a new PR with your changes. Sorry for confusion.

This PR was re-created as #5945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants